Skip to content

Fix graphs not using the global timerange #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 19, 2023
Merged

Fix graphs not using the global timerange #79

merged 2 commits into from
Jun 19, 2023

Conversation

Spikatrix
Copy link

@Spikatrix Spikatrix commented Jun 19, 2023 •
edited by github-actions bot
Loading

Ref https://github.com/fluxninja/cloud/issues/8859

Summary by OpenAI

Bug fix:
- Fixed issue with graphs not displaying correctly by setting default time range to `fnGlobalTimeRange` if it exists and is not equal to the current value
- Removed `value` prop from `TimeRangePicker` component

🎉 Time's mysteries, now we unveil,
With graphs displayed, our quest won't fail.
A picker's change, a bug we quell,
In code's embrace, our triumphs dwell. 🚀

@github-actions
Copy link

github-actions bot commented Jun 19, 2023 •
edited
Loading

🤖 OpenAI

### High-level summary
The changes focus on fixing an issue with graphs not displaying correctly by modifying the default time range behavior in the `Picker` component and removing the `value` prop from the `TimeRangePicker` component. These changes may impact the code behavior and require a thorough review.

| Files                                                                 | Summary                                                                                                                                                 |
|----------------------------------------------------------------------|---------------------------------------------------------------------------------------------------------------------------------------------------------|
| public/app/core/components/TimePicker/TimePickerWithHistory.tsx      | Modifies default time range behavior in `Picker` component and removes `value` prop from `TimeRangePicker` component to fix graph display issues.       |

Chat with 🤖 OpenAI Bot (@openai)

  • Reply on review comments left by this bot to ask follow-up questions. A review comment is a comment on a diff or a file.
  • Invite the bot into a review comment chain by tagging @openai in a reply.

Code suggestions

  • The bot may make code suggestions, but please review them carefully before committing since the line number ranges may be misaligned.
  • You can edit the comment made by the bot and manually tweak the suggestion if it is slightly off.

Ignoring further reviews

  • Type @openai: ignore anywhere in the PR description to ignore further reviews from the bot.

In the recent run, only the files that changed from the base of the PR and between 583aa6d92dbfa0264c2fc1b332011d456fb9e2d2 and 3c8fee11c130bc5445d773fcc056136dad3b440a commits were reviewed.

github-actions[bot]
github-actions bot reviewed Jun 19, 2023
View reviewed changes
@Spikatrix Spikatrix changed the title Fix graphs using default timerange rather than the global timerange Fix graphs not using the global timerange Jun 19, 2023
@Spikatrix Spikatrix merged commit 735ce26 into fluxninja_micro_frontends Jun 19, 2023
@Spikatrix Spikatrix deleted the jaseel/fix-initial-timerange branch June 19, 2023 10:26
@Spikatrix Spikatrix mentioned this pull request Jun 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Spikatrix