Skip to content

Compare raw timerange values #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 19, 2023
Merged

Compare raw timerange values #80

merged 1 commit into from
Jun 19, 2023

Conversation

Spikatrix
Copy link

@Spikatrix Spikatrix commented Jun 19, 2023 •
edited by github-actions bot
Loading

Minor fix, missed it in my previous PR #79

Summary by OpenAI

Bug fix:
- Adjusted TimePicker comparison logic to only compare `raw` properties of time range objects

🎉 A subtle change, a bug we did tame,
Comparing raw, our aim now the same.
TimePicker's logic, improved and refined,
A smoother experience, users will find. 🕰️

@github-actions
Copy link

🤖 OpenAI

Here is the final summary of changes:

High-level summary: The change updates a conditional statement in the Picker component to compare only the raw property of the pickerProps.value object with the raw property of the fnGlobalTimeRange object, instead of comparing the entire objects. This minor adjustment does not impact the overall logic or functionality of the code.

File(s) Summary
public/app/core/components/TimePicker/TimePickerWithHistory.tsx Updated conditional statement in Picker component to compare raw properties of objects instead of entire objects.

Chat with 🤖 OpenAI Bot (@openai)

  • Reply on review comments left by this bot to ask follow-up questions. A review comment is a comment on a diff or a file.
  • Invite the bot into a review comment chain by tagging @openai in a reply.

Code suggestions

  • The bot may make code suggestions, but please review them carefully before committing since the line number ranges may be misaligned.
  • You can edit the comment made by the bot and manually tweak the suggestion if it is slightly off.

Ignoring further reviews

  • Type @openai: ignore anywhere in the PR description to ignore further reviews from the bot.

In the recent run, only the files that changed from the base of the PR and between 735ce2609a7efd35dc202fba30f6dfc96425065d and 1ec935b987a9a36697990c9589a126431cb078cd commits were reviewed.

Files not reviewed due to simple changes (1)

Skipped review in the recent run

  • public/app/core/components/TimePicker/TimePickerWithHistory.tsx

@Spikatrix Spikatrix merged commit 8cb3894 into fluxninja_micro_frontends Jun 19, 2023
@Spikatrix Spikatrix deleted the jaseel/fix-initial-timerange2 branch June 19, 2023 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Spikatrix