Replace rocket tag with acts_as_taggable_on [#480] #279
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#topic_ids was returning ids of both the topics and the tagged user.
2dd7c8b to
3dd27c1
Compare
|
Awesome! Could you remove 636f915 ? It part of another PR . |
There were a few leftovers from rocket_tag in the networks, opportunities and protips controllers. + indentation fix on migration
|
@seuros - I fixed the tests as they tested a lot of the functionality that is modified by this PR. What exactly do you want me to do? Pick out that commit and open another PR? |
3dd27c1 to
e991348
Compare
Space is no longer used as a delimiter anywhere in the codebase. Updated specs. minor fixes
e991348 to
ac2cb88
Compare
mdeiters
added a commit
that referenced
this pull request
Jan 2, 2015
Replace rocket tag with acts_as_taggable_on [#480]
rohitpaulk
added a commit
to rohitpaulk/coderwall
that referenced
this pull request
Jan 10, 2015
This also fixes a small issue that was leftover from coderwall#279
rohitpaulk
added a commit
to rohitpaulk/coderwall
that referenced
this pull request
Jan 10, 2015
This also fixes a small issue that was leftover from coderwall#279
rohitpaulk
added a commit
to rohitpaulk/coderwall
that referenced
this pull request
Jan 10, 2015
Regression from coderwall#279
rohitpaulk
added a commit
to rohitpaulk/coderwall
that referenced
this pull request
Jan 11, 2015
Reorganize Plan model, Remove duplicated uniqueness validations, Fix seeds.rb Regression from coderwall#279, Remove payer_is_team_admin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bounty#480
This PR also restores the ProTip specs.
When deploying, run
bundle installbefore migrating the database.