#6204 Remove remaining inline from variable templates #6218
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Krügler <daniel.kruegler@gmail.com>
|
@CaseyCarter, @jwakely could you please have a look? |
JohelEGP
suggested changes
Mar 29, 2023
source/ranges.tex
Outdated
| @@ -1584,7 +1584,7 @@ | |||
|
|
|||
| \begin{itemdecl} | |||
| template<class R> | |||
| inline constexpr bool @\exposidnc{is-initializer-list}@ = @\seebelow@; // \expos | |||
| constexpr bool @\exposidnc{is-initializer-list}@ = @\seebelow@; // \expos | |||
There was a problem hiding this comment.
Suggested change
| constexpr bool @\exposidnc{is-initializer-list}@ = @\seebelow@; // \expos | |
| constexpr bool @\exposidnc{is-initializer-list}@ = @\seebelow@; // \expos |
Just in case it already was aligned. The check script skips these.
There was a problem hiding this comment.
I hope I fixed it correctly.
There was a problem hiding this comment.
Seems like you added one too many.
JohelEGP
approved these changes
Mar 29, 2023
There was a problem hiding this comment.
All that's missing is following https://github.com/cplusplus/draft/wiki/Commit-message-format#editorial-commits.
jwakely
approved these changes
Mar 29, 2023
jensmaurer
approved these changes
Mar 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.