Skip to content

(library-wide) Remove inline from variable templates #7240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 30, 2024

Conversation

CaseyCarter
Copy link
Contributor

Removes extraneous inline from the definitions of variable templates in [format.syn], [format.tuple], [time.format], [execution.syn], and [exec.util.cmplsig].

Removes extraneous `inline` from the definitions of variable templates in [format.syn], [format.tuple], [time.format], [execution.syn], and [exec.util.cmplsig].
Copy link
Member

@jensmaurer jensmaurer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems straightforward.

@jwakely , any thoughts?

@jwakely
Copy link
Member

jwakely commented Aug 30, 2024

I think making them inline was made unnecessary by CWG 2387, right? If so, I'm fine with dropping inline now.

GCC only implemented that three weeks ago, which might have contributed to my confusion about whether these inline keywords were needed.

@jensmaurer
Copy link
Member

We've had earlier incarnations of inline removal for these cases, e.g. 9568c66 and d2ba9e3 and 9ac5555 .

@jensmaurer jensmaurer merged commit 21e477f into cplusplus:main Aug 30, 2024
2 checks passed
@CaseyCarter CaseyCarter deleted the noinline branch August 30, 2024 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants