Push capable #14
Merged
Push capable #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* solution for cpp-linter#7 * parameterize EXIT_CODE * fix bash function calls; switch to the new docker image * fix bash array length syntax * oops need that apt update * ok now change the test code a bit * check output is working * fix bad yml syntax * is it being set at all? * use a string instead of an integer * fix bash logic syntax * single square brackets are the old way to do logic * review changes * add output var info to the readme * Update demo.cpp * Revert action to upstream master Co-authored-by: shenxianpeng <xianpeng.shen@gmail.com>
This reverts commit fbbb1b5a6f8a80f8d4245ebce07d7048ff74fedd.
|
Your changes look so awesome, I can’t wait to merge them. |
|
Please hold. I'm integrating the new docker image... (& adding the corresponding user input) |
|
Ok, the new image checks out. It did seem to take longer to set up, but its still about 1.5 minutes faster than the other clang-tidy actions on the GH marketplace that also support all available versions. I also added (un-commented) the user option to specify a version in the action.yml |
shenxianpeng
approved these changes
Aug 22, 2021
shenxianpeng
added a commit
that referenced
this pull request
Aug 22, 2021
* #8 update readme to suggest open push event by default * Push capable (#14) * Output exit code (#10) * solution for #7 * parameterize EXIT_CODE * fix bash function calls; switch to the new docker image * fix bash array length syntax * oops need that apt update * ok now change the test code a bit * check output is working * fix bad yml syntax * is it being set at all? * use a string instead of an integer * fix bash logic syntax * single square brackets are the old way to do logic * review changes * add output var info to the readme * Update demo.cpp * Revert action to upstream master * fix dockerfile from image not exist * solution for #7 * parameterize EXIT_CODE * fix bash function calls; switch to new docker image * check output is working * show me some env vars * trigger on push events * switch action to push-capable branch * echo the JSON that lives on the runner * use cat instead of echo * remove backticks * use alpine while debugging git events * Revert "use alpine while debugging git events" This reverts commit fbbb1b5a6f8a80f8d4245ebce07d7048ff74fedd. * test push compatibility * provide version input * docker uses tags * oops update run_checks.sh * fix jq args on push * test push src change * test src change w/ GH checkout * fix filename output for push events (w/ checkouts) * test new comment body * gotta break that bad habit * check against src change * use sed directly instead of sed then cat * tidy docs lied * don't know why sed isn't working * try multiple ARG options * try to replace the docker file * maybe without dyn var * bad domain? * nope needs a docker:// domain * reverting changes to docker file FROM * fix clang-format output to file * test on src changes * list clang-fmt warnings per file * add demo.h and adjust comment body * make test action use default extensions * don't checkout repo on test action * stay in working dir. DL into a hidden file * organize output better * adjust output again * fix output; switch back to checkout repo * enforce CPP syntax in the filename (no checkout) * sed taking too much out of the path in clang-tidy out * that's better (checkout is faster) * segregate script into functions * oops uncomment from debugging locally * show me a long diff * show me a split diff * clean-up (ready for PR) * update readme * remove the version from user inputs * only apply clang-tidy checks if it was specified * switch test action back to upstream * add version for user input Co-authored-by: Brendan <2bndy5@gmail.com>
|
We are pretty fast 😃 see from actions: now it takes |
|
yep that one other action that uses primarily python to create automatic reviews takes about 3m 35s to build the action's image and then about another 1m 30s to execute the action. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Properly resolves #8
Also resolves #6
repo-rootthat allows user to specify a relative path. This makes the action change its working directory to whatever folder the usergit checkouttheir source code to.Observe 2bndy5@f26cabc#commitcomment-55219273 as an example. Incidentally, that commit comment is added to this PR's comments.
tidy-checksto allow specifying a different set of checks passed to clang-tidy. By setting this input to'', this allows users to make clang-tidy use either the default checks or only whatever checks are specified in an optionally accompanied .clang-tidy config file.run_checks.shscript into byte-sized functions and added comments for anything that isn't completely obvious.FROM shenxianpeng/clang-tool:10for behavior consistent with older releases of this action. This too will change as we move to solve Support different versions of clang-format and clang-tidy clang-tools-docker#1