Skip to content

#8 update readme to suggest open push event by default #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 22, 2021

Conversation

shenxianpeng
Copy link
Collaborator

No description provided.

@shenxianpeng shenxianpeng requested a review from 2bndy5 August 19, 2021 03:53
Copy link
Collaborator

@2bndy5 2bndy5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've already tried this in my fork during testing #4 . Push events currently fail because the git API call is specifically tailored to PRs. The logs currently indicate this failure by printing Files = null/files

@2bndy5 2bndy5 mentioned this pull request Aug 22, 2021
@2bndy5 2bndy5 linked an issue Aug 22, 2021 that may be closed by this pull request
Copy link
Collaborator

@2bndy5 2bndy5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll approve this after #14 is merged into this branch

@2bndy5 2bndy5 linked an issue Aug 22, 2021 that may be closed by this pull request
2bndy5 added 2 commits August 22, 2021 15:22
* Output exit code (#10)
* solution for #7
* parameterize EXIT_CODE
* fix bash function calls; switch to the new docker image
* fix bash array length syntax
* oops need that apt update
* ok now change the test code a bit
* check output is working
* fix bad yml syntax
* is it being set at all?
* use a string instead of an integer
* fix bash logic syntax
* single square brackets are the old way to do logic
* review changes
* add output var info to the readme
* Update demo.cpp
* Revert action to upstream master
* fix dockerfile from image not exist
* solution for #7
* parameterize EXIT_CODE
* fix bash function calls; switch to new docker image
* check output is working
* show me some env vars
* trigger on push events
* switch action to push-capable branch
* echo the JSON that lives on the runner
* use cat instead of echo
* remove backticks
* use alpine while debugging git events
* Revert "use alpine while debugging git events"
This reverts commit fbbb1b5a6f8a80f8d4245ebce07d7048ff74fedd.
* test push compatibility
* provide version input
* docker uses tags
* oops update run_checks.sh
* fix jq args on push
* test push src change
* test src change w/ GH checkout
* fix filename output for push events (w/ checkouts)
* test new comment body
* gotta break that bad habit
* check against src change
* use sed directly instead of sed then cat
* tidy docs lied
* don't know why sed isn't working
* try multiple ARG options
* try to replace the docker file
* maybe without dyn var
* bad domain?
* nope needs a docker:// domain
* reverting changes to docker file FROM
* fix clang-format output to file
* test on src changes
* list clang-fmt warnings per file
* add demo.h and adjust comment body
* make test action use default extensions
* don't checkout repo on test action
* stay in working dir. DL into a hidden file
* organize output better
* adjust output again
* fix output; switch back to checkout repo
* enforce CPP syntax in the filename (no checkout)
* sed taking too much out of the path in clang-tidy out
* that's better (checkout is faster)
* segregate script into functions
* oops uncomment from debugging locally
* show me a long diff
* show me a split diff
* clean-up (ready for PR)
* update readme
* remove the version from user inputs
* only apply clang-tidy checks if it was specified
* switch test action back to upstream
* add version for user input
@github-actions
Copy link
Contributor

CLANG-FORMAT WARNINGS:

File: demo.cpp not formatted!
File: demo.hpp not formatted!

@shenxianpeng
Copy link
Collaborator Author

Merge this one as #14 is merged.

Copy link
Collaborator

@2bndy5 2bndy5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had to resolve some conflicts in the merge of #14 and then test the resolutions on this branch. Everything looks good.

@shenxianpeng
Copy link
Collaborator Author

Great, merged!

@shenxianpeng shenxianpeng merged commit 98b1c15 into master Aug 22, 2021
@shenxianpeng shenxianpeng deleted the update-readme branch August 22, 2021 07:36
@shenxianpeng shenxianpeng added the enhancement New feature or request label Oct 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add compatibility for push events Prevent action downloading files after GH checkout action
2 participants