Update guidance for linalg rtol
tolerance cutoff to accommodate non-SVD-like algorithms
#304
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
rtol
inmatrix_rank
,lstsq
andpinv
#216 by updating the guidance forrtol
to accommodate non-SVD-like algorithms. Namely, instead of a strict cutoff of less than or equal to, this PR updates the guidance to say "approximately less than or equal to" to allow conforming implementations some wiggle room should they choose a non-SVD-like algorithm for implementingpinv
. Formatrix_rank
, the API is already defined in terms of singular values, so, in practice, an implementation is likely to be SVD-based; in which case, the more strict guidance is likely to hold.