Skip to content

TST: rework tests for xp_assert_equal #301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 18, 2025
Merged

TST: rework tests for xp_assert_equal #301

merged 1 commit into from
May 18, 2025

Conversation

crusaderky
Copy link
Contributor

  • group tests
  • make test skips and mypy ignores less obnoxious
  • check assertion messages
  • don't rely on strict=False when xfailing
  • Increase coverage for xp_assert_less
  • test that check_dtype=False, check_shape=False don't disable anything else

@crusaderky crusaderky mentioned this pull request May 18, 2025
Merged
@lucascolley lucascolley added this to the 0.8.0 milestone May 18, 2025
@lucascolley lucascolley changed the title TST: rework tests for xp_assert_equal TST: rework tests for xp_assert_equal May 18, 2025
lucascolley
lucascolley approved these changes May 18, 2025
View reviewed changes
Copy link
Member

@lucascolley lucascolley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this seems good, thanks Guido!

@lucascolley lucascolley merged commit dc44205 into data-apis:main May 18, 2025
9 checks passed
@crusaderky crusaderky deleted the test_assert_equal branch June 4, 2025 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucascolley lucascolley lucascolley approved these changes

Assignees
No one assigned
Labels
testing
Projects
None yet
Milestone
0.8.0
Development

Successfully merging this pull request may close these issues.
2 participants
@crusaderky @lucascolley