-
Notifications
You must be signed in to change notification settings - Fork 45
CI: bump numpy version to fix errors #202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
c96d95c
to
da36319
Compare
da36319
to
0074b86
Compare
It looks like this addresses all the |
Thanks @jakevdp, this LGTM. There was still one failure for I opened numpy/numpy#25146 to fix the |
The |
+1 for
I don't understand the current |
Brill thanks both, LGTM.
I'll have a think, I've never used
Personally I had just left the linalg stuff alone as I was hoping #101 would get merged, but I'll have a look as it hasn't moved in like a year lol. |
You use a lot of the benefits of hypothesis using derandomization. It could be useful for this test suite, but I'm not sure I would recommend it for numpy/scipy CI. According to the hypothesis docs if you have a derandomized run you should also have a separate randomized run that can catch bugs. |
You need to do randomized runs either locally or separate from regular CI on PRs. It's like fuzz testing or benchmarking, it does not belong in regular CI. More like benchmarking in that it is also very slow and also looks for regressions. The linked hypothesis docs that suggest a separate nightly cron job are an improvement indeed, although I'd probably do it elsewhere. |
The CI tests check for
iinfo.dtype
andfinfo.dtype
, which were added to NumPy in numpy/numpy#23881 and therefore require a newer NumPy version.Since newer numpy versions are not compatible with Python 3.8, I also bumped the Python versions used by the CI.