UX: display search input and open modal on click #32508
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
82b50dc to
500cd40
Compare
lis2
commented
Apr 30, 2025
| @@ -57,6 +58,10 @@ export default class AdminSidebarStateManager extends Service { | |||
| this.sidebarState.isForcingSidebar = false; | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
I need it because importing when I import admin/components/modal/admin-search in admin-sidebar.js it was failing for non admin users.
lis2
commented
Apr 30, 2025
| @icon="magnifying-glass" | ||
| class="btn-transparent sidebar-search__icon" | ||
| /> | ||
| {{! template-lint-disable no-pointer-down-event-binding }} |
There was a problem hiding this comment.
I need mousedown because mouseup is too late. I want to prevent input to get focus, so when modal is closed, the user cannot type anything into this fake input.
tgxworld
reviewed
Apr 30, 2025
app/assets/javascripts/discourse/app/components/sidebar/panel-header.gjs
Outdated
Show resolved
Hide resolved
tgxworld
reviewed
Apr 30, 2025
app/assets/javascripts/discourse/app/components/sidebar/search.gjs
Outdated
Show resolved
Hide resolved
tgxworld
reviewed
Apr 30, 2025
tgxworld
approved these changes
Apr 30, 2025
In this PR we hide search input. #32485 However, search input is much more intuitive. Therefore, input was brought back and opens modal on click. In addition, search link was removed.
…header.gjs Co-authored-by: Alan Guo Xiang Tan <gxtan1990@gmail.com>
0292973 to
1e58818
Compare
This was referenced May 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR we hide search input.
#32485
However, search input is much more intuitive. Therefore, input was brought back and opens modal on click. In addition, search link was removed.
Demo:
https://github.com/user-attachments/assets/5b193fab-918e-4a4d-9fdd-97c92c534850
Mobile:
