FIX: remove sidebar filter #32485
Merged
FIX: remove sidebar filter #32485
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove sidebar filter in favour of search. In addition: - Search was moved up just below Dashboard; - Do not perform search when filter is empty; - Display "no results".
c5cd260 to
e3d3a9d
Compare
tgxworld
reviewed
Apr 28, 2025
tgxworld
reviewed
Apr 28, 2025
| @@ -91,7 +101,9 @@ export default class AdminSearch extends Component { | |||
| changeSearchTerm(event) { | |||
| this.searchResults = []; | |||
| this.filter = event.target.value; | |||
| this.runSearch(); | |||
| if (this.filter.length > 0) { | |||
| this.runSearch(); | |||
There was a problem hiding this comment.
Not directly related to this PR but I don't think we are debouncing search at all.
There was a problem hiding this comment.
It is debounced a bit later:
tgxworld
approved these changes
Apr 28, 2025
lis2
added a commit
that referenced
this pull request
Apr 29, 2025
In this PR we hide search input. #32485 However, search input is much more intuitive. Therefore, input was brought back and opens modal on click. In addition, search link was removed.
lis2
added a commit
that referenced
this pull request
Apr 29, 2025
In this PR we hide search input. #32485 However, search input is much more intuitive. Therefore, input was brought back and opens modal on click. In addition, search link was removed.
lis2
added a commit
that referenced
this pull request
Apr 29, 2025
In this PR we hide search input. #32485 However, search input is much more intuitive. Therefore, input was brought back and opens modal on click. In addition, search link was removed.
lis2
added a commit
that referenced
this pull request
Apr 29, 2025
In this PR we hide search input. #32485 However, search input is much more intuitive. Therefore, input was brought back and opens modal on click. In addition, search link was removed.
lis2
added a commit
that referenced
this pull request
Apr 29, 2025
In this PR we hide search input. #32485 However, search input is much more intuitive. Therefore, input was brought back and opens modal on click. In addition, search link was removed.
lis2
added a commit
that referenced
this pull request
Apr 29, 2025
In this PR we hide search input. #32485 However, search input is much more intuitive. Therefore, input was brought back and opens modal on click. In addition, search link was removed.
lis2
added a commit
that referenced
this pull request
Apr 30, 2025
In this PR we hide search input. #32485 However, search input is much more intuitive. Therefore, input was brought back and opens modal on click. In addition, search link was removed.
lis2
added a commit
that referenced
this pull request
May 1, 2025
In this PR we hide search input. #32485 However, search input is much more intuitive. Therefore, input was brought back and opens modal on click. In addition, search link was removed.
lis2
added a commit
that referenced
this pull request
May 1, 2025
In this PR we hide search input. #32485 However, search input is much more intuitive. Therefore, input was brought back and opens modal on click. In addition, search link was removed.
lis2
added a commit
that referenced
this pull request
May 21, 2025
In this PR, filter was removed and replaced by search. #32485 However, moderator should still be able to filter sidebar. Also, plugins like `doc-category` should have filterable sidebar.
lis2
added a commit
that referenced
this pull request
May 21, 2025
In this PR, filter was removed and replaced by search. #32485 However, moderator should still be able to filter sidebar. Also, plugins like `doc-category` should have filterable sidebar.
lis2
added a commit
that referenced
this pull request
May 21, 2025
In this PR, filter was removed and replaced by search. #32485 However, moderator should still be able to filter sidebar. Also, plugins like `doc-category` should have filterable sidebar.
lis2
added a commit
that referenced
this pull request
May 21, 2025
In this PR, filter was removed and replaced by search. #32485 However, moderator should still be able to filter sidebar. Also, plugins like `doc-category` should have filterable sidebar.
lis2
added a commit
that referenced
this pull request
May 22, 2025
In this PR, filter was removed and replaced by search. #32485 However, moderator should still be able to filter sidebar. Also, plugins like doc-category should have filterable sidebar.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove sidebar filter in favour of search.
In addition: