DEV: replace select-kit utils mixin methods with input-utils lib #32594
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjaffeux
approved these changes
May 6, 2025
tyb-talks
added a commit
that referenced
this pull request
May 23, 2025
Follow up to refactoring the generic utils mixin used in select-kit components in #32594. This PR follows a different approach as the util functions related to properties here aren't easily extracted without a major change to the interface due to the dependency on `this.selectKit`. These util functions are instead declared on the prototype with a class decorator which ensures the same behaviour is maintained without relying on a mixin. It's largely a lift-and-shift with some minor refactoring of the conditional logic to reduce nesting and improve readability of the functions.
martin-brennan
pushed a commit
that referenced
this pull request
Jun 10, 2025
) This PR replaces the set of methods related to validation and normalization of input values in the select-kit utils mixin with simple exported functions from a input-utils lib file. We maintain the `_normalize` method on the select-kit component because there are external repos dependent on that part of the interface. We'll replace the remainder of the mixin with another utils lib file in a separate PR.
martin-brennan
pushed a commit
that referenced
this pull request
Jun 10, 2025
Follow up to refactoring the generic utils mixin used in select-kit components in #32594. This PR follows a different approach as the util functions related to properties here aren't easily extracted without a major change to the interface due to the dependency on `this.selectKit`. These util functions are instead declared on the prototype with a class decorator which ensures the same behaviour is maintained without relying on a mixin. It's largely a lift-and-shift with some minor refactoring of the conditional logic to reduce nesting and improve readability of the functions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the set of methods related to validation and normalization of input values in the select-kit utils mixin with simple exported functions from a input-utils lib file.
We maintain the
_normalizemethod on the select-kit component because there are external repos dependent on that part of the interface.We'll replace the remainder of the mixin with another utils lib file in a separate PR.