-
Notifications
You must be signed in to change notification settings - Fork 8.5k
DEV: Modernize the remaining of the post stream to Glimmer components #32653
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
megothss
wants to merge
45
commits into
main
Choose a base branch
from
dev/glimmer-post-stream-phase-2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaced the old scrolling post stream with a new `PostStream` Glimmer component when `useGlimmerPostStream` is enabled. Added conditional rendering for loading indicators and integrated the actions for post loading. Loading more posts above and below is working, although the scroll tracking is not implemented yet.
The topic route template now checks which version of the PostStream is enabled in the settings and uses the correct component.
…oading posts above
Replaced private method prefixes and streamlined debounce calls for improved clarity. Introduced private fields for better encapsulation and removed unused properties to reduce clutter. Adjusted SLACK_FACTOR and updated relevant calculations for more precise screen tracking.
Reorganized method placements, renamed a method for clarity, and corrected parameter usage in the `updateIntersectionObservers` function. These changes improve code readability and maintainability while preserving existing functionality.
Ensure methods properly handle cases where there are no visible posts. Prevents errors by adding null checks and skipping unnecessary observer updates. Improves resilience of post tracking logic during edge cases.
Introduce bottom eyeline tracking for improved scroll position monitoring for the posts in the bottom of the page in the post-stream component. Added a debug mode for visualizing the eyeline position, along with various cleanup and restructuring to support this feature. Updated event handling, intersection observers, and DOM manipulation accordingly.
Fixes an issue where the post observer was not properly re-attached when bottom eyeline tracking was disabled. Ensures the observer's state is correctly updated to avoid inconsistent behavior during scroll events.
Debugging `console.log` statements used for development purposes have been removed to clean up the code.
This change ensures touchmove events trigger the same scroll logic across devices, improving consistency in user interactions. The corresponding cleanup logic for touchmove was also added to ensure proper event listener removal.
Adjusted the scrollable area and progress calculation to handle scenarios where the viewport height exceeds the document height or results in a non-scrollable area. This ensures accurate progress tracking and prevents division by zero errors.
This commit introduces logic to enable bottom eyeline tracking only when the current post's height exceeds the viewport height. It also optimizes the scrolling tracking behavior by removing unnecessary debounce usage, improving performance and clarity. These changes ensure better handling of large posts and enhance user experience during scrolling.
This commit introduces a more robust system for eyeline tracking, ensuring proper handling when the current post height exceeds the viewport. The changes streamline debounce logic, improve observer interactions, and make the code more modular for maintainability.
Replaced `&&` with `||` to ensure the condition checks each boundary independently. This prevents incorrect behavior when only one of the boundaries changes.
Ensure the current post remains tracked only if it is visible on screen. Adds a check to confirm the current post is within on-screen boundaries, improving accuracy during scrolling.
Updated event listeners to use new handler methods `#postedTriggered` and `#scrollTriggered`. This improves readability and ensures consistent handling of post stream actions like jumping to posts and responding to refresh events.
Replaced hash with lazyHash for outletArgs in the topic-above-posts plugin outlet.
This change simplifies the current post tracking and intersection observer logic.
Introduce a `highlightTerm` getter in `post-stream` and update `post` components to use the passed property instead of directly accessing `this.search.highlightTerm`. This ensures better encapsulation and consistent data flow between components.
…ost numbers instead of using nth-last-of-type selectors which were producing unexpected results. Also refactored the loading indicators placement to remove them from the post-stream wrapper div
Updated `disableCloaking` to use the import path for `post-stream` components and added `disableWidgetCloaking` for widgets. This avoids potential test issues.
Ensure post nodes are removed from the `observedPostNodes` set before unobserving them with cloaking and viewport observers.
Comment on lines
+101
to
+106
// restore scroll position on browsers with aggressive BFCaches (like Safari) | ||
window.onpageshow = function (event) { | ||
if (event.persisted) { | ||
DiscourseURL.routeTo(this.location.pathname); | ||
} | ||
}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this was a bugfix for old safari
Comment on lines
+88
to
+90
// TODO (glimmer-post-stream) do we need this? | ||
this.appEvents.on("post-stream:posted", this, this.#postedTriggered); | ||
this.appEvents.on("post-stream:refresh", this, this.#scrollTriggered); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we try removing these and see if tests pass?
Updated the CSS selector in the composer test to correctly target the last topic post. This ensures the test reliably checks the intended element.
Corrected `lastPostedAt` to `last_posted_at` to match the expected property format.
Removed unused tracking of on-screen boundaries to streamline the component logic. Replaced `if` with `unless` in template conditionals for better readability and consistency.
The sticky-avatar class is now conditionally applied in components for non-mobile views, preparing for future Glimmer integration. Added the `widget-post-stream` class to restrict the old modifier logic to widgets. Added TODOs to remove legacy modifiers once fully transitioned.
Converted plain properties to @Tracked in `post-stream` and `post` models for better reactivity handling. This ensures improved state management and aligns with Ember's tracked properties approach.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.