DEV: Modernize the remaining of the post stream to Glimmer components #32653
+1,130
−522
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaced the old scrolling post stream with a new `PostStream` Glimmer component when `useGlimmerPostStream` is enabled. Added conditional rendering for loading indicators and integrated the actions for post loading. Loading more posts above and below is working, although the scroll tracking is not implemented yet.
The topic route template now checks which version of the PostStream is enabled in the settings and uses the correct component.
…oading posts above
Replaced private method prefixes and streamlined debounce calls for improved clarity. Introduced private fields for better encapsulation and removed unused properties to reduce clutter. Adjusted SLACK_FACTOR and updated relevant calculations for more precise screen tracking.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.