Skip to content

UX: simplify admin search, make more accessible #32733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 15, 2025

Conversation

awesomerobot
Copy link
Member

This simplifies the admin search and adds some basic accessibility

Simplification:

  • Removes the filters for now, both in the modal and full-screen
  • Removes the link to full-screen from the modal
  • Simpler input placeholder text
  • Positioned to sit higher on the page, similar to a command palette

Accessibility:

  • Results (or lack of) announced for screenreaders after query

Bonus:

  • Makes the modal input sticky on scroll
  • Combined some styles shared between this and the chat menu (modifier + k) under a --quick-palette class

Before:
image

After:

image

@github-actions github-actions bot added chat PRs which include a change to Chat plugin i18n PRs which update English locale files or i18n related code labels May 14, 2025
@SamSaffron SamSaffron merged commit 231b394 into main May 15, 2025
16 checks passed
@SamSaffron SamSaffron deleted the ux-improve-admin-search branch May 15, 2025 06:31
chapoi added a commit that referenced this pull request May 27, 2025
Potentially due specificity changes in #32733 , the `max-modal-width` is
undefined when rendering mobile, resulting in:


![image](https://github.com/user-attachments/assets/8bd8551b-a52e-46a1-92cc-7a3e79db042d)

Despite my expecting the MQ to take preference, it doesn't:
![CleanShot 2025-05-27 at 12 16
08@2x](https://github.com/user-attachments/assets/a897564d-0173-4442-82df-8d5dbaa3411d)

This commit:
* Added a fallback 
* Increased specificity for good measure
* Fixed border-radius (should be zero, aligned with top and full-width)

![CleanShot 2025-05-27 at 12 23
56@2x](https://github.com/user-attachments/assets/9d43ce30-424a-4855-ad43-1b915d251f0d)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chat PRs which include a change to Chat plugin i18n PRs which update English locale files or i18n related code
Development

Successfully merging this pull request may close these issues.

3 participants