PERF: Introduce lazyHash and update PluginOutlet calls to use it #32823
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CvX
reviewed
May 20, 2025
f0a8ea0 to
032231c
Compare
CvX
approved these changes
May 21, 2025
| } | ||
|
|
||
| // Like ember's builtin hash helper, but instead of returning a reified object | ||
| // every time its referenced, it returns a static proxy object with auto-trackable keys. |
There was a problem hiding this comment.
Suggested change
| // every time its referenced, it returns a static proxy object with auto-trackable keys. | |
| // every time it's referenced, it returns a static proxy object with auto-trackable keys. |
This is a more efficient version of `{{hash`, where the values are only evaluated when they're actually accessed
We don't actually need a proxy, since the set of keys on an internalHelper can never change
no need to set up the LazyHash object until something actually accesses it (the most common case for PluginOutlet is for it to be unused)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a more efficient version of
{{hash, where the values are only evaluated when they're actually accessedAlso bumps
@discourse/lint-configs, which now includes an ember-template-lint rule to ensure{{hash}}is not reintroduced