Skip to content

PERF: Introduce lazyHash and update PluginOutlet calls to use it #32823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

PERF: Introduce lazyHash and update PluginOutlet calls to use it #32823

wants to merge 3 commits into from
+613 −469

Conversation

davidtaylorhq
Copy link
Member

This is a more efficient version of {{hash, where the values are only evaluated when they're actually accessed

Also bumps @discourse/lint-configs, which now includes an ember-template-lint rule to ensure {{hash}} is not reintroduced

@github-actions github-actions bot added the chat PRs which include a change to Chat plugin label May 20, 2025
CvX
CvX reviewed May 20, 2025
View reviewed changes
@davidtaylorhq
PERF: Introduce lazyHash and update PluginOutlet calls to use it
51bcf8b 
This is a more efficient version of `{{hash`, where the values are only evaluated when they're actually accessed
@davidtaylorhq
remove unused imports
b088554
@davidtaylorhq
improvements
170a9dd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CvX CvX CvX left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
chat PRs which include a change to Chat plugin
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davidtaylorhq @CvX