FIX: bring back sidebar filter #32837
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b0ec1a6 to
2a7cb99
Compare
In this PR, filter was removed and replaced by search. #32485 However, moderator should still be able to filter sidebar. Also, plugins like `doc-category` should have filterable sidebar.
2a7cb99 to
c3dea02
Compare
OsamaSayegh
approved these changes
May 22, 2025
app/assets/javascripts/discourse/app/lib/sidebar/admin-sidebar.js
Outdated
Show resolved
Hide resolved
Comment on lines
+60
to
+62
| get filterable() { | ||
| return false; | ||
| } |
There was a problem hiding this comment.
What is the difference between filterable and searchable? To me they sound like they're the same thing, so maybe we should include a comment here to clarify what each one does?
|
This pull request has been mentioned on Discourse Meta. There might be relevant details there: https://meta.discourse.org/t/discourse-doc-categories/322376/123 |
|
This pull request has been mentioned on Discourse Meta. There might be relevant details there: |
lis2
added a commit
to discourse/discourse-doc-categories
that referenced
this pull request
May 27, 2025
Spec was removed here #38 Because we brought back filter functionality, it is working again - discourse/discourse#32837 Meta: https://meta.discourse.org/t/discourse-doc-categories/322376/123
lis2
added a commit
to discourse/discourse-doc-categories
that referenced
this pull request
May 30, 2025
Spec was removed here #38 Because we brought back filter functionality, it is working again - discourse/discourse#32837 Meta: https://meta.discourse.org/t/discourse-doc-categories/322376/123
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, filter was removed and replaced by search.
#32485
However, moderator should still be able to filter sidebar. Also, plugins like
doc-categoryshould have filterable sidebar.Moderator:
https://github.com/user-attachments/assets/2604930f-c69a-4ac2-bdac-9ad94eead4bb
Doc category plugin
https://github.com/user-attachments/assets/9ad9f5b4-9d2c-4c2d-9005-e31822acfaab