Skip to content

FIX: automatically skip create confirm when plugin is enabled #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 20, 2025
Merged

FIX: automatically skip create confirm when plugin is enabled #11

merged 1 commit into from
May 20, 2025

Conversation

ZogStriP
Copy link
Member

This is dependent on discourse/discourse#32824 being merged.

@ZogStriP ZogStriP requested a review from pmusaraj May 20, 2025 18:13
pmusaraj
pmusaraj approved these changes May 20, 2025
View reviewed changes
Copy link
Contributor

@pmusaraj pmusaraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, this makes sense for the current state. If eventually we move the authenticator here into core, we might need to revisit, but for now, this could work well.

@ZogStriP ZogStriP merged commit 5dd93e5 into main May 20, 2025
2 of 4 checks passed
@ZogStriP ZogStriP deleted the skip-create-confirm branch May 20, 2025 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmusaraj pmusaraj pmusaraj approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ZogStriP @pmusaraj