-
-
Notifications
You must be signed in to change notification settings - Fork 32.8k
Fixed #36430 -- Removed artificially low limit on single field bulk operations on SQLite. #19522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Fixed #36430 -- Removed artificially low limit on single field bulk operations on SQLite. #19522
Conversation
208e3a9
to
e1bb0bf
Compare
buildbot, test on oracle. |
e1bb0bf
to
4e0e25b
Compare
cba3892
to
26cbf1d
Compare
…perations on SQLite.
26cbf1d
to
17dce75
Compare
buildbot, test on oracle. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, this looks good to me 👍
qs.in_bulk([self.au1.id, self.au2.id], field_name="author_id"), | ||
{self.au1.id: self.a4, self.au2.id: self.a5}, | ||
list(qs.in_bulk([self.a5.id, self.a4.id, self.a3.id, self.a2.id])), | ||
[5, 4, 2, 3], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might be nice to adjust the other test to remove distinct() at the same time. I should also see if I can use articles 1, 2, 3, 4 instead. There's also a postgres & mysql failure, so I need to adjust the expected result or skip the test. I can find a minute in the next few days to get that in.
Trac ticket number
ticket-36430
Branch description
Thanks @laymonage for analysis on the ticket about why this limit should no longer be relevant.
Checklist
main
branch.