Fixed #36430 -- Removed artificially low limit on single field bulk operations on SQLite. #19522
+25
−28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
208e3a9 to
e1bb0bf
Compare
|
buildbot, test on oracle. |
e1bb0bf to
4e0e25b
Compare
cba3892 to
26cbf1d
Compare
sarahboyce
reviewed
Aug 7, 2025
…perations on SQLite.
26cbf1d to
17dce75
Compare
|
buildbot, test on oracle. |
sarahboyce
approved these changes
Aug 11, 2025
jacobtylerwalls
commented
Aug 11, 2025
| qs.in_bulk([self.au1.id, self.au2.id], field_name="author_id"), | ||
| {self.au1.id: self.a4, self.au2.id: self.a5}, | ||
| list(qs.in_bulk([self.a5.id, self.a4.id, self.a3.id, self.a2.id])), | ||
| [5, 4, 2, 3], |
There was a problem hiding this comment.
It might be nice to adjust the other test to remove distinct() at the same time. I should also see if I can use articles 1, 2, 3, 4 instead. There's also a postgres & mysql failure, so I need to adjust the expected result or skip the test. I can find a minute in the next few days to get that in.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trac ticket number
ticket-36430
Branch description
Thanks @laymonage for analysis on the ticket about why this limit should no longer be relevant.
Checklist
mainbranch.