Add method that allows to monkeypatch how models are filtered #6817
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c7237db to
7c1f4fb
Compare
7c1f4fb to
9d57d9c
Compare
This was referenced Mar 10, 2020
|
Closing this as the approach won't give us the desirable outcome that we need. This coupled together with versioning renders the object in the wrong way. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Instead of monkeypatching entire block of methods in djangocms-versioning we can monkeypatch single small methods to accomplish the same thing.
This PR adds a method
filter_admin_model. The intended use for this method is to be able to fetch objects that are in draft in djangocms-versioning, that package will monkeypatch that method to modify the behaviour so that draft objects can be found.Checklist
release/4.0.x