Skip to content

Pin diff match patch #1978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Pin diff match patch #1978

wants to merge 1 commit into from

Conversation

andrewgy8
Copy link
Member

@andrewgy8 andrewgy8 commented Oct 21, 2024 •
edited
Loading

Problem

Closes #1694

@coveralls
Copy link

Coverage Status

coverage: 100.0%. remained the same
when pulling da868fe on pin-diff-match-patch
into 1b54c1a on main.

matthewhegarty
matthewhegarty requested changes Oct 22, 2024
View reviewed changes
Copy link
Contributor

@matthewhegarty matthewhegarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good thanks - we have to pin in pyproject.toml as well

@matthewhegarty
Copy link
Contributor

I've added this change to #1979 as well

@andrewgy8
Copy link
Member Author

Thanks for that. Seems like there is some work to be done there to avoid this confusion. I suggest we move everything over to the new standard of pyproject.toml.

@andrewgy8 andrewgy8 reopened this Oct 24, 2024
@andrewgy8 andrewgy8 closed this Oct 24, 2024
@matthewhegarty
Copy link
Contributor

I think we have to have both because pyproject.toml is for packaging and base.txt is for local dev

@andrewgy8 andrewgy8 mentioned this pull request Oct 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewhegarty matthewhegarty matthewhegarty requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

diff_match_patch replacement
3 participants
@andrewgy8 @coveralls @matthewhegarty