Skip to content

Migrate all requirement files to pyproject.toml #1982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 24, 2024
Merged

Migrate all requirement files to pyproject.toml #1982

merged 2 commits into from
Oct 24, 2024

Conversation

andrewgy8
Copy link
Member

@andrewgy8 andrewgy8 commented Oct 24, 2024 •
edited
Loading

Problem

Requirements should be simple and only managed in one place to avoid confusion. See #1978

Solution

  • Migrate all txt requirement files to pyproject.toml

matthewhegarty
matthewhegarty approved these changes Oct 24, 2024
View reviewed changes
Copy link
Contributor

@matthewhegarty matthewhegarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great - thanks

@coveralls
Copy link

Coverage Status

coverage: 100.0%. remained the same
when pulling 2bdfb25 on migrate-all-to-pyproject
into 414bd4b on main.

@andrewgy8 andrewgy8 merged commit 82263e5 into main Oct 24, 2024
14 checks passed
@andrewgy8 andrewgy8 deleted the migrate-all-to-pyproject branch October 24, 2024 11:33
@matthewhegarty
Copy link
Contributor

I think it has to be:

pip install '.[tests]'

Not

pip install .[tests]

@andrewgy8
Copy link
Member Author

It depends on you terminal interface 🙃

For zsh you need to enclose with quotes but for others you do not need to.

It also works via make.

@andrewgy8 andrewgy8 mentioned this pull request Oct 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewhegarty matthewhegarty matthewhegarty approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andrewgy8 @coveralls @matthewhegarty