-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Add StartInterval to health check since it will be supported by the 1.44 docker API #2244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for the PR, @henri-tremblay. Can you please add a test for it? Consider using something like this |
I would normally say: "Sure!" But it do not see any test about health check. I don't know what you would expect me to do using the test you pointed out. |
Then is a good time to add it :)
Given this change is specific to a docker version then take into account the |
I have added tests. However they do not work because the container doesn't seem to use the health check and I have no idea why. Could you please have a look? |
According to the docs:
This new attribute is beta, so it will take some time to be available in GHA. Once available, I'll test it locally and merge it accordingly. |
thanks for the fix on the test! |
Thanks for your contribution, @henri-tremblay ! I tested this locally and it works. |
Awesome. Thanks to you. Will be useful to me right away. |
See here for the change on the docker side.