Skip to content

Add StartInterval to health check since it will be supported by the 1.44 docker API #2244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Feb 2, 2024

Conversation

henri-tremblay
Copy link
Contributor

See here for the change on the docker side.

@henri-tremblay henri-tremblay requested a review from a team as a code owner November 10, 2023 16:32
@eddumelendez
Copy link
Member

Thanks for the PR, @henri-tremblay. Can you please add a test for it? Consider using something like this

@henri-tremblay
Copy link
Contributor Author

I would normally say: "Sure!" But it do not see any test about health check. I don't know what you would expect me to do using the test you pointed out.

@eddumelendez
Copy link
Member

But it do not see any test about health check.

Then is a good time to add it :)

I don't know what you would expect me to do using the test you pointed out.

Given this change is specific to a docker version then take into account the assumeThat line :)

@henri-tremblay
Copy link
Contributor Author

I have added tests. However they do not work because the container doesn't seem to use the health check and I have no idea why. Could you please have a look?

@eddumelendez
Copy link
Member

eddumelendez commented Dec 19, 2023

According to the docs:

The test to perform. Possible values are:

[] inherit healthcheck from image or parent image
["NONE"] disable healthcheck
["CMD", args...] exec arguments directly
["CMD-SHELL", command] run command with system's default shell

This new attribute is beta, so it will take some time to be available in GHA. Once available, I'll test it locally and merge it accordingly.

@henri-tremblay
Copy link
Contributor Author

thanks for the fix on the test!

@eddumelendez eddumelendez added this to the next milestone Jan 25, 2024
@eddumelendez eddumelendez merged commit 7957a14 into docker-java:main Feb 2, 2024
@eddumelendez
Copy link
Member

Thanks for your contribution, @henri-tremblay ! I tested this locally and it works.

@henri-tremblay
Copy link
Contributor Author

Awesome. Thanks to you. Will be useful to me right away.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants