-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Add Network create attribute #2344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Network create attribute #2344
Conversation
/assign @eddumelendez |
Hi, thanks for the PR. I don't see the created attribute in Network create operation https://docs.docker.com/engine/api/v1.45/#tag/Network/operation/NetworkCreate |
Thanks for your quick review. Then I guess it is only valido for inspect. in that case, should I create a new object for inspectNetworkResponse?, to just add this attribute to it? https://docs.docker.com/engine/api/v1.45/#tag/Network/operation/NetworkInspect |
Oh ok, it belongs to the inspect network response. There is similar things for containers so let's keep it as it. It should be reviewed in the future. |
Checking createNetwork return a CreateNetworkResponse, it does not contains createTime. Network Object is used to return Network information, it contains the creation time |
Some unrelated test are failing, not sure why. |
Thanks for your contribution, @juanmolle ! |
This PR Parse Create attribute from Network Object
Related: #2343