Skip to content

Add Network create attribute #2344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

juanmolle
Copy link
Contributor

@juanmolle juanmolle commented Jun 24, 2024

This PR Parse Create attribute from Network Object

Related: #2343

@juanmolle juanmolle requested a review from a team as a code owner June 24, 2024 16:03
@juanmolle
Copy link
Contributor Author

/assign @eddumelendez

@eddumelendez
Copy link
Member

Hi, thanks for the PR. I don't see the created attribute in Network create operation https://docs.docker.com/engine/api/v1.45/#tag/Network/operation/NetworkCreate

@juanmolle
Copy link
Contributor Author

juanmolle commented Jun 24, 2024

Thanks for your quick review. Then I guess it is only valido for inspect. in that case, should I create a new object for inspectNetworkResponse?, to just add this attribute to it?

https://docs.docker.com/engine/api/v1.45/#tag/Network/operation/NetworkInspect

@eddumelendez
Copy link
Member

Oh ok, it belongs to the inspect network response. There is similar things for containers so let's keep it as it. It should be reviewed in the future.

@juanmolle
Copy link
Contributor Author

Checking createNetwork return a CreateNetworkResponse, it does not contains createTime. Network Object is used to return Network information, it contains the creation time

@juanmolle
Copy link
Contributor Author

Some unrelated test are failing, not sure why.

@eddumelendez eddumelendez added this to the next milestone Jul 9, 2024
@eddumelendez eddumelendez merged commit 242c76a into docker-java:main Jul 9, 2024
5 checks passed
@eddumelendez
Copy link
Member

Thanks for your contribution, @juanmolle !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants