Clean bootstrap artifacts #78
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Are these the only places we use |
$ git grep -i boot
1.5/alpine/Dockerfile:ENV GOLANG_BOOTSTRAP_VERSION 1.4.3
1.5/alpine/Dockerfile:ENV GOLANG_BOOTSTRAP_URL https://golang.org/dl/go$GOLANG_BOOTSTRAP_VERSION.src.tar.gz
1.5/alpine/Dockerfile:ENV GOLANG_BOOTSTRAP_SHA1 486db10dc571a55c8d795365070f66d343458c48
1.5/alpine/Dockerfile: && mkdir -p /usr/local/bootstrap \
1.5/alpine/Dockerfile: && wget -q "$GOLANG_BOOTSTRAP_URL" -O golang.tar.gz \
1.5/alpine/Dockerfile: && echo "$GOLANG_BOOTSTRAP_SHA1 golang.tar.gz" | sha1sum -c - \
1.5/alpine/Dockerfile: && tar -C /usr/local/bootstrap -xzf golang.tar.gz \
1.5/alpine/Dockerfile: && cd /usr/local/bootstrap/go/src \
1.5/alpine/Dockerfile: && export GOROOT_BOOTSTRAP=/usr/local/bootstrap/go \
1.5/alpine/Dockerfile: && rm -rf /usr/local/bootstrap /usr/local/go/pkg/bootstrap \
1.6/alpine/Dockerfile:ENV GOLANG_BOOTSTRAP_VERSION 1.4.3
1.6/alpine/Dockerfile:ENV GOLANG_BOOTSTRAP_URL https://golang.org/dl/go$GOLANG_BOOTSTRAP_VERSION.src.tar.gz
1.6/alpine/Dockerfile:ENV GOLANG_BOOTSTRAP_SHA1 486db10dc571a55c8d795365070f66d343458c48
1.6/alpine/Dockerfile: && mkdir -p /usr/local/bootstrap \
1.6/alpine/Dockerfile: && wget -q "$GOLANG_BOOTSTRAP_URL" -O golang.tar.gz \
1.6/alpine/Dockerfile: && echo "$GOLANG_BOOTSTRAP_SHA1 golang.tar.gz" | sha1sum -c - \
1.6/alpine/Dockerfile: && tar -C /usr/local/bootstrap -xzf golang.tar.gz \
1.6/alpine/Dockerfile: && cd /usr/local/bootstrap/go/src \
1.6/alpine/Dockerfile: && export GOROOT_BOOTSTRAP=/usr/local/bootstrap/go \
1.6/alpine/Dockerfile: && rm -rf /usr/local/bootstrap /usr/local/go/pkg/bootstrap \
update.sh: # 1.4 is our "bootstrap" version for all future versions
update.sh: s/^(ENV GOLANG_BOOTSTRAP_VERSION) .*/\1 '"$fullVersion"'/;
update.sh: s/^(ENV GOLANG_BOOTSTRAP_SHA256) .*/\1 '"$srcSha256"'/;
update.sh: s/^(ENV GOLANG_BOOTSTRAP_SHA1) .*/\1 '"$srcSha1"'/; |
|
Nice, and nice catch, @client9! 👍 LGTM |
|
https://travis-ci.org/docker-library/golang/builds/102705940 (they're green -- I don't feel like waiting for 1.4 which hasn't changed here 😄) |
yosifkit
added a commit
to infosiftr/stackbrew
that referenced
this pull request
Jan 18, 2016
- `golang` make alpine variant a little smaller docker-library/golang#78 - `julia` bump `0.4.3` - `mysql` docker-library/mysql#126 - `postgres` `9.4.5-2` - `python` docker-library/python#82 - `rabbitmq` docker-library/rabbitmq#58
RichardScothern
pushed a commit
to RichardScothern/official-images
that referenced
this pull request
Jun 14, 2016
- `golang` make alpine variant a little smaller docker-library/golang#78 - `julia` bump `0.4.3` - `mysql` docker-library/mysql#126 - `postgres` `9.4.5-2` - `python` docker-library/python#82 - `rabbitmq` docker-library/rabbitmq#58
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unsure if
/usr/local/go/testshould be deleted, so left it for now.Fixes #77.