Skip to content

Implement TODO for -Eeuo #827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Implement TODO for -Eeuo #827

wants to merge 1 commit into from

Conversation

clairmont32
Copy link

I noticed the TODO comment for switching to -Eeuo when reviewing the entrypoint for 13.2. I did the switch after searching for a PR that does this but couldnt find one.

implements TODO comment
@tianon
Copy link
Member

tianon commented Mar 16, 2021

So, to clarify, the reason this is a TODO is because we need to carefully test all the workflows we reasonably can and make sure at least all the code in this script doesn't break. 😅

(Just adding -u is the easy bit 🙈 ❤️)

@clairmont32
Copy link
Author

I figured it might be a bit easier said than done since it wasn't already completed but wanted to submit it just in case it was missed in this particular file. How do you want me to proceed to help?

@tianon
Copy link
Member

tianon commented Mar 22, 2021

Sorry -- I think the first step would be to enumerate all the things we want/need to test. The best place to start with that (IMO) is looking through the script for all the "configurable bits" (environment variables we actually act upon) so we can create a plan for verifying that they all still work appropriately.

Essentially anywhere we call file_env or have an if with a variable, we should figure out a plan for testing that the relevant code still works with -u enabled. 👍

@yosifkit
Copy link
Member

If we do add -u, that would be likely breaking for more users than we expect for their initdb.d scripts:

echo "$0: sourcing $f"
. "$f"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants