Skip to content

set -u for docker-entrypoint.sh #964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 16, 2022
Merged

set -u for docker-entrypoint.sh #964

merged 1 commit into from
Jun 16, 2022

Conversation

fjf2002
Copy link
Contributor

@fjf2002 fjf2002 commented May 31, 2022

I think POSTGRES_INITDB_WALDIR is the only case an undefined variable is used. Fixed.

@tianon
Copy link
Member

tianon commented May 31, 2022

See #827 for some important/useful previous discussion on this.

@fjf2002
Copy link
Contributor Author

fjf2002 commented Jun 1, 2022

@tianon: Thanks for pointing that out.
Well, then let us state that "POSTGRES_INITDB_WALDIR is ONE case where an undefined variable is used."
I have removed the "set -u" from this PR; the other changes can be considered as "one step towards set -u" ?

@tianon tianon merged commit b979def into docker-library:master Jun 16, 2022
docker-library-bot added a commit to docker-library-bot/official-images that referenced this pull request Jun 17, 2022
Changes:

- docker-library/postgres@b979def: Merge pull request docker-library/postgres#964 from fjf2002/patch-1
- docker-library/postgres@74e51d1: prep for possible `set -u` in docker-entrypoint.sh
docker-library-bot added a commit to docker-library-bot/official-images that referenced this pull request Jun 17, 2022
Changes:

- docker-library/postgres@2f6878c: Update 14 to 14.4, bullseye 14.4-1.pgdg110+1
- docker-library/postgres@b979def: Merge pull request docker-library/postgres#964 from fjf2002/patch-1
- docker-library/postgres@74e51d1: prep for possible `set -u` in docker-entrypoint.sh
BaurzhanSakhariev pushed a commit to crate/official-images that referenced this pull request Jul 18, 2022
Changes:

- docker-library/postgres@2f6878c: Update 14 to 14.4, bullseye 14.4-1.pgdg110+1
- docker-library/postgres@b979def: Merge pull request docker-library/postgres#964 from fjf2002/patch-1
- docker-library/postgres@74e51d1: prep for possible `set -u` in docker-entrypoint.sh
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants