[RFC] Add 3.5/alpine variant #74
Conversation
|
Seems that the tests are failing due to missing bash and readline. Those were intentionally excluded so I guess we need to fix the test suite. |
|
Figured I'd just PR my comments so they're easier to discuss and/or incorporate: ncopa#1 😄 |
…ge size in half by keeping fetch and compile in the same layer so the Python source goes away properly Before: ~163.2 MB After: ~89.05 MB
Adjust whitespace for better symmetry between Dockerfiles and cut image size in half by keeping fetch and compile in the same layer so the Python source goes away properly
|
I've restarted the CI job now that the test is fixed -- this LGTM (going to wait for CI to come back green though) |
|
Oh right, readline. We'll need to do something with that test, but I don't think this is worth holding up on account of that. 👍 |
|
Hmm, it does only add ~2.75 MB to install. Still worth considering just adding it, since it's a core Python module -- does installing it after the fact enable the core module, or does it have to be built in during Python source compilation time? If it's hard or impossible to add after the fact, then I think we need to just include it unilaterally, but if we can add it afterwards without too much trouble, then we're fine and need to fix the test. |
$ docker run -it --rm python:alpine sh
/ # apk add --no-cache readline
fetch http://dl-4.alpinelinux.org/alpine/v3.3/main/x86_64/APKINDEX.tar.gz
fetch http://dl-4.alpinelinux.org/alpine/v3.3/community/x86_64/APKINDEX.tar.gz
(1/1) Installing readline (6.3.008-r4)
Executing busybox-1.24.1-r7.trigger
OK: 13 MiB in 18 packages
/ # python
Python 3.5.1 (default, Dec 31 2015, 22:51:08)
[GCC 5.3.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import readline
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
ImportError: No module named 'readline'
>>> 😞 😢 BUT! The silver lining is that we already have the deps of |
- `docker`: alpine:3.3 (docker-library/docker#7) - `drupal`: 8.0.2 - `java`: explicit `JAVA_HOME` (docker-library/openjdk#61) - `php`: 5.5.31, 5.6.17, 7.0.2; fix edge case in `docker-php-ext-enable` (docker-library/php#172) - `postgres`: 9.5.0; set `PGDATA` perms to `0700` (docker-library/postgres#110) - `python`: add `alpine` variant for 3.5 (docker-library/python#74) - `rabbitmq`: fix SSL bugs (docker-library/rabbitmq#55, docker-library/rabbitmq#56) - `wordpress`: 4.4.1
- `docker`: alpine:3.3 (docker-library/docker#7) - `drupal`: 8.0.2 - `java`: explicit `JAVA_HOME` (docker-library/openjdk#61) - `php`: 5.5.31, 5.6.17, 7.0.2; fix edge case in `docker-php-ext-enable` (docker-library/php#172) - `postgres`: 9.5.0; set `PGDATA` perms to `0700` (docker-library/postgres#110) - `python`: add `alpine` variant for 3.5 (docker-library/python#74) - `rabbitmq`: fix SSL bugs (docker-library/rabbitmq#55, docker-library/rabbitmq#56) - `wordpress`: 4.4.1
This is a continuation of #71 which was deleted by mistake.
I have made incremental changes for displaying the progress. I can merge the patches into a single before we merge it into docker-library if wanted.