More parsing improvements #2016
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… symbolResults dictionary
* Option -> Symbol -> Option * Argument -> Symbol -> Argument
…ment key the value can be only ArgumentResult etc
… Root very quickly
don't create the enumerable more than once
jonsequitur
reviewed
Jan 12, 2023
| result = result.Parent; | ||
| } | ||
|
|
||
| Debug.Assert(result is RootCommandResult); |
There was a problem hiding this comment.
We've avoided using Debug.Assert in the past. We should discuss.
jonsequitur
approved these changes
Jan 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most likely the best way to review this PR is to read each commits description