Python 3 Support #227
Merged
Python 3 Support #227
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into feature/py3
|
"All is well". Niiiiiice. What do you say to some Python 3 support? |
| Python 2 returns a value in the range [-2**31, 2**31-1]. | ||
| Python 3 returns a value in the range [0, 2**32-1]. | ||
|
|
||
| We want a consistent behavior so let's use python2's. |
There was a problem hiding this comment.
this seems wrong to me. see https://docs.python.org/3.1/library/binascii.html#binascii.crc32
CRC is only important in binary pack form b/c that is what is sent to the broker. does struct.pack('>i', crc) behave differently on py2 v. py3 ?
There was a problem hiding this comment.
It appears so:
kafka-python $ python3
Python 3.4.1 (default, Sep 3 2014, 10:12:05)
>>> import struct, binascii
>>> struct.pack('<i', binascii.crc32(b'abcd'))
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
struct.error: 'i' format requires -2147483648 <= number <= 2147483647
kafka-python $ python
Python 2.7.6 (default, Sep 3 2014, 10:15:09)
>>> import struct, binascii
>>> struct.pack('<i', binascii.crc32(b'abcd'))
'\x11\xcd\x82\xed'
Closed
|
+1 but needs rebase to merge automatically |
Closed
Closed
|
nice! big +1 for this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates PR #224, with fixed tests.