increase serializer compatibility to django 1.8 #2857
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
i ran into this issue when using v2.4 with django v1.8. (i didn't previously read it isn't supported) It's not in the release notes but django.db.model.Options many_to_many() now returns an ImmutableList which is really just a tuple with a bunch of warnings and hooks on it. if we don't make this typecast change we get the following error TypeError: can only concatenate tuple (not "list") to tuple I'm not sure if this change is appropriate and not sure what, if any, additional tests to include with this . I attempted to test this but must be doing something wrong. Every test fails when trying to use cursor. most of the errors I get are Failed: Database access not allowed, use the "django_db" mark to enable i followed the instructions here. https://github.com/tomchristie/django-rest-framework/blob/version-2.4.x/CONTRIBUTING.md
|
Actually, the |
|
cool. great to hear. look forward to the merge. thanks. |
|
Just dropping by to express my anticipation for this merge as well :) keep up the good work. |
xordoquy
added a commit
that referenced
this pull request
May 4, 2015
increase serializer compatibility to django 1.8
|
Now that's what I was looking for :) legacy API should be happy now... |
nikolas
added a commit
to ccnmtl/wacep
that referenced
this pull request
Aug 24, 2015
Fixes this problem with django 1.8: encode/django-rest-framework#2857
nikolas
added a commit
to nikolas/django-rest-framework
that referenced
this pull request
Aug 24, 2015
Might be useful for catching any more django 1.8 issues like this one: encode#2857
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i ran into this issue when using v2.4 with django v1.8. (i didn't previously read it isn't supported)
It's not in the release notes but django.db.model.Options many_to_many() now returns an ImmutableList which is really just a tuple with a bunch of warnings and hooks on it.
if we don't make this typecast change we get the following error
I'm not sure if this change is appropriate and not sure what, if any, additional tests to include with this .
I attempted to test this but must be doing something wrong.
Every test fails when trying to use cursor. most of the errors I get are
i followed the instructions here.
https://github.com/tomchristie/django-rest-framework/blob/version-2.4.x/CONTRIBUTING.md