Test 2.4.x series on django 1.8 #3327
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Might be useful for catching any more django 1.8 issues like this one: encode#2857
|
I'm reluctant to merge failing test in particular since we do not support 1.8 yet |
|
Note that you can already test against 1.8 with tox |
|
These tests were failing because I didn't set it up correctly.. I'll try and fix that. 2.4.8 does work with 1.8, this fix is 1.8-specific so I thought it was supported.. I just thought having the automated tests run on 1.8 would help ensure that it's working. |
|
2.4.8 somewhat works with 1.8. Unless the full test suite passes, we can't tell for sure it does support it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Might be useful for catching any more django 1.8 issues like this one:
#2857