Skip to content

Implement invert for HardwareSerial #6816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Nov 20, 2019

Conversation

dok-net
Copy link
Contributor

@dok-net dok-net commented Nov 20, 2019

Fixes #4896

@Jeroen88
Copy link
Contributor

Isn't it a bit counter intuitive to use uart_set_baudrate() to set inversion? Wouldn't it be better to have an additional low level function _uart_set_inversion(bool invert) that reads USC0 and clears or sets the bits for inversion?

@dok-net
Copy link
Contributor Author

dok-net commented Nov 20, 2019

@Jeroen88 what are you talking about, it's uart_init()

@Jeroen88
Copy link
Contributor

@dok-net You are right, my mistake... :)

@dok-net
Copy link
Contributor Author

dok-net commented Nov 20, 2019

The CI failure is (again) nothing to do with the PR, but network / setup related?

… that has these flags defined and documented.
@earlephilhower
Copy link
Collaborator

Looks like Sphinx (the doc generator) is barfing again on installation.

@earlephilhower
Copy link
Collaborator

#6817 will make CI work again, then you can update and the CI should then pass.

@morganchristiansson
Copy link

morganchristiansson commented Sep 15, 2022

This is not documented @ https://arduino-esp8266.readthedocs.io/en/latest/reference.html#serial ? Had to read PR to figure out usage. Found no other leads searching on Google.

Serial.begin(115200, SERIAL_8N1, SERIAL_FULL, 1, true); // true = invert

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Serial doesn't provide inverse operation as provided by Espressif
7 participants