-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Implement invert for HardwareSerial #6816
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Isn't it a bit counter intuitive to use uart_set_baudrate() to set inversion? Wouldn't it be better to have an additional low level function _uart_set_inversion(bool invert) that reads USC0 and clears or sets the bits for inversion? |
@Jeroen88 what are you talking about, it's uart_init() |
@dok-net You are right, my mistake... :) |
The CI failure is (again) nothing to do with the PR, but network / setup related? |
… that has these flags defined and documented.
064f7a5
to
ae75059
Compare
Looks like Sphinx (the doc generator) is barfing again on installation. |
#6817 will make CI work again, then you can update and the CI should then pass. |
This is not documented @ https://arduino-esp8266.readthedocs.io/en/latest/reference.html#serial ? Had to read PR to figure out usage. Found no other leads searching on Google.
|
Fixes #4896