Skip to content

Extra PR (on top of #4050) for #4046: BLEDevice::deinit(false) should clear initialized. #4085

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 0 commits into from

Conversation

geeksville
Copy link
Contributor

Thanks to @vicatcu for the base PR. @chegewara would you mind checking this change - see my comment in this commit.

@chegewara
Copy link
Contributor

There is too many unnecessary changes. I doubt it will be accepted the way it is by @me-no-dev

@geeksville
Copy link
Contributor Author

geeksville commented Jun 13, 2020

@chegewara My commit is only one line. The PR above it is just a massive copy of your tree I think? (see #4050)

@chegewara
Copy link
Contributor

Thats the problem. Mentioned PR makes too many changes, by copying from Kolban's repository, which will discard all PRs made here for some time.
Kolban's repository has few updates that could be used here, but some changes in this library are not compatible.

@geeksville
Copy link
Contributor Author

ok understood - sorry I thought you were working on that branch! I agree then, I didn't realize the two trees had diverged.

@geeksville
Copy link
Contributor Author

geeksville commented Jun 13, 2020

Though it is a good datapoint, because that branch definitely fixed nasty BLE corruptions I was seeing.

@vicatcu
Copy link
Contributor

vicatcu commented Jun 13, 2020

to be clear, my PR was extremely naive transfer of diffs. I would also not be shocked if it were not accepted, but something needs to happen...

geeksville added a commit to geeksville/Meshtastic-esp32 that referenced this pull request Jun 13, 2020
We need our own branch because we need this fix and associated pullrequest
espressif/arduino-esp32#4085
@geeksville
Copy link
Contributor Author

geeksville commented Jun 13, 2020

@chegewara and @me-no-dev:

Okay now that I know it isn't a matter of the other branch being the only one that is updated. And not knowing the history - I'd like to ask some advice:

  • I just looked into the root cause of this bug and I can make a nice clean small commit that fixes just this one issue. I will submit it shortly. (the fix is straightforward)
  • What is the history of these two 'branches' - it looks like there was more recent engineering in the other one? Any idea of if there are valuable fixes missing from this one?
  • Is there any sense that either of the two branches are particularly more robust? (I have no idea - I've just been using arduino-esp32 on my project)

@geeksville geeksville marked this pull request as draft June 13, 2020 19:09
@geeksville geeksville closed this Jun 13, 2020
@chegewara
Copy link
Contributor

Its hard to say, because i dont follow code in any of them for some time. I have my own code that i am using and if something is not working i am fixing it.
In Kolban's repo there is few fixes that get merged after arduino started using its own code, and in arduino code there is few fixes since then.
Currently i am providing mostly support with my knowledge, answering questions etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants