-
Notifications
You must be signed in to change notification settings - Fork 7.6k
Extra PR (on top of #4050) for #4046: BLEDevice::deinit(false) should clear initialized. #4085
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There is too many unnecessary changes. I doubt it will be accepted the way it is by @me-no-dev |
@chegewara My commit is only one line. The PR above it is just a massive copy of your tree I think? (see #4050) |
Thats the problem. Mentioned PR makes too many changes, by copying from Kolban's repository, which will discard all PRs made here for some time. |
ok understood - sorry I thought you were working on that branch! I agree then, I didn't realize the two trees had diverged. |
Though it is a good datapoint, because that branch definitely fixed nasty BLE corruptions I was seeing. |
to be clear, my PR was extremely naive transfer of diffs. I would also not be shocked if it were not accepted, but something needs to happen... |
We need our own branch because we need this fix and associated pullrequest espressif/arduino-esp32#4085
@chegewara and @me-no-dev: Okay now that I know it isn't a matter of the other branch being the only one that is updated. And not knowing the history - I'd like to ask some advice:
|
Its hard to say, because i dont follow code in any of them for some time. I have my own code that i am using and if something is not working i am fixing it. |
Thanks to @vicatcu for the base PR. @chegewara would you mind checking this change - see my comment in this commit.