Added Node v16 to the test suite #1731
Merged
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should I add some timeouts to the Github actions, so they don't run for more than x minutes? |
Yeah, it a good idea. Test runner sometimes gets stuck. I have no idea why, so the timeout will work fine. |
|
@Siemienik I created one here #1733. When this PR is merged, could you provide me with some basic help to get a failing test up and running? Because the simple writable stream example from the Read.me does not work with Node.js v16 🧐 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
v16 is a new major version of Node.js, let's make sure to add test case of this.
Related to (at least) issue #1594