Added timeouts to github actions #1733
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cclauss
approved these changes
Sep 24, 2021
|
There is no problem with a never-ending timeout, so I don't see the value of these changes. Could you explain your motivation? |
|
Global warming?!? Why cook the planet with tests that do not deliver value? |
Siemienik
approved these changes
Nov 21, 2021
There was a problem hiding this comment.
We have never situation like that. But ok, for the same reason, there are no concerns to introduce timeouts.
If are you really care about global warming, feel invited to open a PR with performance optimization. This will affect for much more apps than only a few actions.
This was referenced Sep 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
No need for actions running hour after hour - doing nothing 🌎 ☘️