Skip to content

Basic shape support added #2077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Basic shape support added #2077

wants to merge 2 commits into from

Conversation

DantSu
Copy link

@DantSu DantSu commented Jun 14, 2022 •
edited
Loading

Summary

This PR adds basic shapes support.

  • Parse existing shapes in XLSX file
  • Methods in worksheet to list existing shapes and add new one
  • Save it in XLSX file.

Test plan

Adding a new shape in a Worksheet

      ws.addShape(
          {
            shape: Shape.DOWN_ARROW,
            rotation: 45,
            fill : {color: '4499FF', opacity: 0.6},
            stroke: {color: '88AAFF', opacity: 1, weight: 2}
          },
          {
            tl: {col: 19, row: 31},
            ext: {width: 120, height: 50}
          }
        )

will result to :

arrow_down

Below a list of tested shapes :

Shape.LINE = 'line';
Shape.RECTANGLE = 'rect';
Shape.ROUND_RECTANGLE = 'roundRect';
Shape.ELLIPSE = 'ellipse';
Shape.TRIANGLE = 'triangle';
Shape.RIGHT_ARROW = 'rightArrow';
Shape.DOWN_ARROW = 'downArrow';
Shape.LEFT_BRACE = 'leftBrace';
Shape.RIGHT_BRACE = 'rightBrace';

@DantSu DantSu changed the title basic shape support added Basic shape support added Jun 14, 2022
@DantSu
Copy link
Author

DantSu commented Jul 7, 2022

this project is still maintained ?

@tttclz
Copy link

tttclz commented Aug 3, 2022

great work!
hope this can be merged

@Siemienik Siemienik self-assigned this Apr 6, 2023
@zurmokeeper
Copy link
Contributor

@DantSu Could you please move over here? I'd be happy to merge this feature.

@zurmokeeper zurmokeeper mentioned this pull request Aug 5, 2023
Closed
This was referenced Nov 5, 2023
Open
Open
kiroInn
kiroInn approved these changes Nov 6, 2023
View reviewed changes
Copy link

@kiroInn kiroInn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This was referenced Nov 24, 2023
Open
Open
@kigh-ota
Copy link
Contributor

I am one of those who wants this feature, so I created another PR with a few additional functionalities and no conflicts based on this.
#2601
I highly appreciate this PR, and hope that this feature would be realized (doesn't matter which PR would be merged).
Any suggestions are welcome :)

@DantSu
Copy link
Author

DantSu commented Nov 24, 2023

I'm sorry to say that, but you lost your time. ExcelJS is not maintained anymore. I have open this PR a year and a half ago.... nothing has happened since. Look the comment of @zurmokeeper, he have fork and maintain it. You can PR on this fork.

@kigh-ota
Copy link
Contributor

Thank you for the comment!

I have open this PR a year and a half ago.... nothing has happened since.

Yes, I feel sorry about that. Have you already moved to the fork, DantSu?

I'm not sure whether ExcelJS is no longer maintained, because recently I found a post saying @Siemienik would like to make the project active again and a new version 4.4.0 would have been released #2351.
Maybe we can expect that the project would gain momentum.
Of course, it's a pity that this PR is not yet reviewed or merged...

@DantSu
Copy link
Author

DantSu commented Nov 25, 2023

I haven't see this post, this is a great news for this great library. I hope my PR wil be merged.

I haven't migrate to the fork, I haven't time for this, feel free to do this.

@kigh-ota
Copy link
Contributor

kigh-ota commented Nov 25, 2023 •
edited
Loading

I agree with you and thank you for the permission! I create a PR if I have time.

@Siemienik
Copy link
Member

Siemienik commented Nov 25, 2023 •
edited
Loading

So yes, this project is becoming active again after a long time. I apologize if this causes any inconvenience. I'm doing everything I can to keep it alive, even though it's more of a volunteer effort for me. Please leave a thumbs-up 👍 on the PRs that are most important to you, as this is a key factor for me in deciding which ones to review next. Also, your activity in the pinned discussions is very helpful, especially if you would like to see something included in the next release.
#2573 #2574

I also encourage you to be active on our Discord:

SiemaTeam

@DantSu
Copy link
Author

DantSu commented Nov 26, 2023

@Siemienik Thank you for your answer, you don't have to apologize. Open source project in sleeping mode is very common, and nobody has to complain. I thought the project was abandoned, because in most open source project it is.

@baian1 baian1 mentioned this pull request Jan 12, 2025
Open
4 tasks
@zurmokeeper zurmokeeper mentioned this pull request Jan 13, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fr34kyn01535 fr34kyn01535 fr34kyn01535 approved these changes

@kiroInn kiroInn kiroInn approved these changes

At least 1 approving review is required to merge this pull request.

Assignees

@Siemienik Siemienik

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@DantSu @tttclz @zurmokeeper @kigh-ota @Siemienik @fr34kyn01535 @kiroInn