fix: inefficient merge check for large amount of merged cells within … #2691
Conversation
| // apply merge | ||
| const master = this.getCell(dimensions.top, dimensions.left); | ||
| // check cells aren't already merged | ||
| if (master.isMerged()) { |
There was a problem hiding this comment.
isMerged is not a function, its a getter so you need this.
| if (master.isMerged()) { | |
| if (master.isMerged) { |
There was a problem hiding this comment.
@markygab I'm sorry, I didn't notice your review until now, and I am super busy at work and home with something else. Are you or anyone else able to apply your suggestions and test them? I recall that I did test my functionality in my own application, and it seemed to work, but perhaps I just didn't notice there was a bug somewhere.
There was a problem hiding this comment.
Or, if you need me to, I could use the github UI to apply suggestions, so you could review again. Let me know. :)
| this.getCell(i, j).merge(master, ignoreStyle); | ||
| cell = this.getCell(i, j); | ||
| // check cells aren't already merged | ||
| if (cell.isMerged()) { |
|
I've applied the suggested comments on this PR: #2920 (preserving the author's commit) |
When there are a lot of merged cells within a worksheet, e.g. 30.000 merged cells (e.g. the same 2 cells are merged in every row in a 30.000 row table), parsing mergeCells is increasingly slow. This is due to the inefficient conflict check within
_mergeCellsInternal(dimensions, ignoreStyle)in worksheet.js.Summary
My motivation is to let these big files function, rather than load forever. I believe the massive check is unnecessary. Rather than check every other merged range, can't you just see if any of the cells in the new range are merged, and then throw an error?
I do not know the original motivation for the
throw new Error('Cannot merge already merged cells');error, and whether it always breaks the program, or if the error is caught somewhere. Hopefully the new implementation is much more efficient without breaking anything.Test plan
See the issue #2689
I have attached a file there. Loading that file goes from 1.5 minutes in node JS to only seconds. In the browser that file just will not load.
Related to source code (for typings update)