Skip to content

place pageSetUpPr in the end of sheetPr to fix getting broken xlsx do… #2807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

place pageSetUpPr in the end of sheetPr to fix getting broken xlsx do… #2807

wants to merge 1 commit into from

Conversation

strelok372
Copy link

@strelok372 strelok372 commented Aug 12, 2024 •
edited
Loading

Summary

Fix for this bug
#1348

Test plan

const workbook = new ExcelJS.Workbook();

workbook.creator = 'Me';

const worksheet = workbook.addWorksheet('My Sheet', {
    pageSetup: {paperSize: 9, orientation: 'landscape', fitToPage: true, fitToHeight: 0}
});

const filename = "result.xlsx"
workbook.xlsx.writeFile(filename);

This code won't work in the 4.4.0 version, you will get an error while opening xlsx file
The problem code is fitToPage: true

Related to source code (for typings update)

exceljs/lib/xlsx/xform/sheet/sheet-properties-xform.js

Line 28 in 5bed18b

inner = this.map.pageSetUpPr.render(xmlStream, model.pageSetup) || inner;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@strelok372