Revert "Add process output for flutter_tester test and unskip" #18871
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 5d8ea59.
|
Er, the build failed; but it doesn't seem like the same test :/ I'm going to land this anyway to put things back as they were and I'll do some more digging into this after lunch. It feels like this is flaky, but it's weird that it's always been green until I started merging things (story of my life)! Travis failure here is npm related (it's been intermittent all morning), the Flutter build failure is from the changeset this is reverting. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to revert #18868 if it fails (we suspect it will, but it has some additional logging in which might reveal why - since it doesn't fail anywhere except
mac_bot).I won't land it until after that changeset has built (and failed) on
mac_bot. If it doesn't fail, then I'll just abort this PR and we'll have to wait until it fails to see if the log contains the info.