Skip to content

Can Address Line 2 field (or similar) be added? #593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mikebronner opened this issue Mar 20, 2017 · 5 comments
Closed

Can Address Line 2 field (or similar) be added? #593

mikebronner opened this issue Mar 20, 2017 · 5 comments

Comments

@mikebronner
Copy link
Member

@ellisio posted in the GeocoderLaravel issues list (geocoder-php/GeocoderLaravel#52) the following request:

When parsing an address with an apartment number, you receive a "Subpremise" attribute. This attribute is typically mapped to an "Address Line 2".

For example: https://maps.googleapis.com/maps/api/geocode/json?address=2123%20W%20Mineral%20Ave%20Apt%2061,%20Littleton,%20CO%2080120

It would be nice to have this added as the subpremise on the Address object.

Is this something you would consider adding? Or any thoughts on work-arounds?

Thanks!
~Mike
@mikebronner mikebronner mentioned this issue Mar 20, 2017
Closed
@Nyholm
Copy link
Member

Nyholm commented May 30, 2017

Does it make sense to add "getSubpremise" to the GoogleAddress? When/how often does subpremise exist in the response from google?

Ping @svrdlic

@svrdlic
Copy link
Contributor

svrdlic commented Jun 1, 2017 •
edited
Loading

From google maps docs: subpremise indicates a first-order entity below a named location, usually a singular building within a collection of buildings with a common name.

‘Subpremise’ is what Google Maps return just in case that query address contains Apt/Suite/Unit number. I think it wont hurt if we add this, if someone adds it in query, it would be nice to get it back :)

@Nyholm
Copy link
Member

Nyholm commented Jun 1, 2017

Okey, good.

Can you submit a PR that adds supremise to the GoogleAddress?

@svrdlic
Copy link
Contributor

svrdlic commented Jun 1, 2017

Sure

@svrdlic svrdlic mentioned this issue Jun 2, 2017
Merged
@Nyholm
Copy link
Member

Nyholm commented Jun 17, 2017

Closed by #657

@Nyholm Nyholm closed this as completed Jun 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Nyholm @mikebronner @svrdlic