Skip to content

Updating for Laravel 5.3 #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 19 commits into from
Closed

Updating for Laravel 5.3 #48

wants to merge 19 commits into from

Conversation

mikebronner
Copy link
Member

@mikebronner mikebronner commented Sep 30, 2016 •
edited
Loading

This PR brings the package up to par with Geocoder 3.3.x, as well as addresses bugs and adds new functionality, resolving most of the open issues.

This is a backwards-compatibility-breaking update, so it should be versioned as 0.7.0. Please read the updated README and CHANGELOG for all the details.

Currently, Travis is failing due to a CURL bug, but locally tests are all green. There are some additional tests that are missing in order to get code coverage up, but I will add them in a following PR, so as not to hold this one up.

@mikebronner mikebronner self-assigned this Sep 30, 2016
@coveralls
Copy link

coveralls commented Sep 30, 2016 •
edited
Loading

Coverage Status

Coverage decreased (-0.6%) to 95.652% when pulling 3f1d8b6 on GeneaLabs:feature/update-for-laravel-5-3 into 9069849 on geocoder-php:master.

@coveralls
Copy link

coveralls commented Sep 30, 2016 •
edited
Loading

Coverage Status

Coverage decreased (-0.6%) to 95.652% when pulling 34b6148 on GeneaLabs:feature/update-for-laravel-5-3 into e801a11 on geocoder-php:master.

This was referenced Sep 30, 2016
Closed
Closed
@coveralls
Copy link

coveralls commented Sep 30, 2016 •
edited
Loading

Coverage Status

Coverage decreased (-0.6%) to 95.652% when pulling 4cab9bc on GeneaLabs:feature/update-for-laravel-5-3 into e801a11 on geocoder-php:master.

@mikebronner mikebronner added this to the 0.7 milestone Oct 1, 2016
@mikebronner mikebronner changed the title [WIP] Updating for Laravel 5.3 Updating for Laravel 5.3 Oct 1, 2016
@mikebronner
Copy link
Member Author

@toin0u and @willdurand, this PR is ready for review. I know this PR could have been split into multiple smaller ones, but I am eager to get these updates out. Looking forward to your feedback!

@coveralls
Copy link

Coverage Status

Coverage decreased (-32.3%) to 64.0% when pulling 8f07737 on GeneaLabs:feature/update-for-laravel-5-3 into e801a11 on geocoder-php:master.

@coveralls
Copy link

coveralls commented Oct 2, 2016 •
edited
Loading

Coverage Status

Coverage decreased (-37.6%) to 58.73% when pulling c4b423c on GeneaLabs:feature/update-for-laravel-5-3 into e801a11 on geocoder-php:master.

@mikebronner
Copy link
Member Author

Looks like the test failures are due to a Travis bug. Ignoring for now ... I am able to run the package's unit tests locally just fine in isolation (no laravel app required) now.

@willdurand
Copy link
Member

@mikebronner I'll review the PR next week. Did you setup coveralls or was it already there?

willdurand
willdurand reviewed Oct 2, 2016
View reviewed changes
CHANGELOG.md
### Changed
- README documentation.
- to use Geocoder 3.3.x.
- namespace to `Geocoder\Laravel\...`.
Copy link
Member

@willdurand willdurand Oct 2, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

then, let's use 1.0.0 as version, not 0.7.0

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good :) Should we start off with 1.0.0-RC as there are bound to be a few small wrinkles, like code coverage, additional test, and run it in a few projects?

@mikebronner
Copy link
Member Author

Hi @willdurand, Travis and coveralls was allready there. I am in the process of setting up a CI solution that should be a tad better suited for this, and after that I will work on increasing code coverage with additional tests for the classes added.

@coveralls
Copy link

coveralls commented Oct 3, 2016 •
edited
Loading

Coverage Status

Coverage decreased (-37.6%) to 58.73% when pulling cfd14a7 on GeneaLabs:feature/update-for-laravel-5-3 into e801a11 on geocoder-php:master.

@mikebronner mikebronner mentioned this pull request Oct 4, 2016
Merged
@mikebronner
Copy link
Member Author

Closing in favor of #49.

@mikebronner mikebronner closed this Oct 4, 2016
@alexc-hollywood alexc-hollywood mentioned this pull request Jun 13, 2017
Closed
@foziazahoor foziazahoor mentioned this pull request Aug 3, 2017
Closed
@darkcast64 darkcast64 mentioned this pull request Aug 22, 2019
Closed
@sheinfeld sheinfeld mentioned this pull request Mar 4, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willdurand willdurand willdurand left review comments

Assignees

@willdurand willdurand

@toin0u toin0u

@mikebronner mikebronner

Labels
enhancement
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@mikebronner @coveralls @willdurand @toin0u