Add support for validating discussion description #14
Conversation
| elif [[ $is_discussion = true ]]; then | ||
| gh api graphql -F discussionId="$discussion_node_id" -F body="$message" -f query=' | ||
| mutation($discussionId: ID!, $body: String!) { | ||
| addDiscussionComment(input: {discussionId: $discussionId, body: $body}) { |
There was a problem hiding this comment.
replyToId (The Node ID of the discussion comment within this discussion to reply to.) might be useful when we add discussion comments
|
Doing some minor refactors for readability! Please hold! |
action.yml
Outdated
| target=" your pull request body" | ||
| elif [ ${{ github.event.discussion && !github.event.comment }} ]; then |
There was a problem hiding this comment.
My only thought is since this is the only option using graphql what if we just moved the graphql command into this if statement?
There was a problem hiding this comment.
We will want to make this call based on the result of flag="$(flagAltText "$content")" which happens later! So I think we should keep the graphql command where it is!
I did some additional refactors which may help with readability.
| comment_owner=${{ github.event.pull_request.user.login }} | ||
| is_pr=true | ||
| target=" your pull request body" | ||
| else |
There was a problem hiding this comment.
We can assume that else will be anything that's not a comment event, instead of having the check in every elif:
elif [ ${{ github.event.issue && !github.event.comment }} ];
| issue=${{ github.event.issue.html_url }} | ||
| comment_owner=${{ github.event.comment.user.login }} | ||
| is_pr=${{ github.event.issue.pull_request.url != '' }} | ||
| content=$COMMENT |
There was a problem hiding this comment.
I renamed comment to content and comment_owner to user, since comment might be confusing given it's association with github.event.comment. We're setting these variables for non-comment events too.
| comment=$COMMENT | ||
| issue=${{ github.event.issue.html_url }} | ||
| comment_owner=${{ github.event.comment.user.login }} | ||
| is_pr=${{ github.event.issue.pull_request.url != '' }} |
There was a problem hiding this comment.
I changed this is_pr variable to be type, and set to one of:
issue_descriptionissue_commentpr_descriptionpr_commentdiscussion_description
I think this will make what we're dealing with more clear.
|
👋 Hello and thanks for pinging us! You've entered our first responder queue. An accessibility first responder will review this soon.
|
|
@khiga8 We may want to update the readme description too:
|
| @@ -1,6 +1,6 @@ | |||
| # Accessibility-alt-text-bot | |||
|
|
|||
| This action supports accessible content sharing on GitHub by leaving an automated reminder whenever an image is shared on a GitHub Issue or Pull request without meaningful alternative text (alt text). | |||
| This action supports accessible content sharing on GitHub by leaving an automated reminder whenever an image is shared on a GitHub Issue, Pull request, or Discussion without meaningful alternative text (alt text). | |||
Part of: #11